suggest explicit braces to avoid ambiguous

kdenetwork-1052214/kopete/protocols/groupwise/gwaccount.cpp: 540

defined but not used

kdenetwork-1052214/kopete/protocols/qq/libeva.h: 118

#warning Fix KNotification here

kdenetwork-1052214/kopete/protocols/yahoo/yahooaccount.cpp: 1572, 1584

NULL used in arithmetic

kdenetwork-1052214/kopete/plugins/otr/otrlconfinterface.cpp: 111

assuming signed overflow does not occur when assuming that > X is always false

/usr/include/QtCore/qbytearray.h: 444

[with T = QString]

kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/kcmsambaconf.cpp: 1149

redefined

kdenetwork-1052214/kopete/libkopete/kopete_export.h: 163

#warning check if QString != means using isNull or isEmpty

kdenetwork-1052214/kppp/requester.cpp: 234

#warning Currently using metaContact->picture.path but should use replacement of KopeteMimeSourceFactory

kdenetwork-1052214/kopete/kopete/contactlist/contactlistmodel.cpp: 592

#warning Port or remove this KToolBar hack

kdenetwork-1052214/kopete/protocols/yahoo/yahoochatsession.cpp: 149

#warning Item::paintCell needs fixing

kdenetwork-1052214/kopete/libkopete/ui/kopetelistviewitem.cpp: 1216

type qualifiers ignored on function return type

kdenetwork-1052214/kopete/libkopete/kopetecommand.h: 91

passing argument of discards qualifiers from pointer target type

kdenetwork-1052214/kopete/protocols/yahoo/libkyahoo/libyahoo.c: 302

pointer targets in passing argument of differ in signedness

kdenetwork-1052214/kopete/protocols/yahoo/libkyahoo/libyahoo.c: 274

deprecated conversion from string constant to

kdenetwork-1052214/kopete/protocols/jabber/libiris/iris/xmpp/xmpp-core/xmpp_stanza.cpp: 271

extra tokens at end of #endif directive

kdenetwork-1052214/kopete/protocols/yahoo/libkyahoo/yahoo_fn.h: 38

suggest parentheses around comparison in operand of

kdenetwork-1052214/kopete/plugins/otr/otrlchatinterface.cpp: 569

#warning No icon shown, we should go away from QPixmap genered icons with overlays.

kdenetwork-1052214/kopete/libkopete/kopeteaccount.cpp: 405

#warning A null parent is a weird choice. Any reason?

kdenetwork-1052214/kppp/pwentry.cpp: 37

is not defined

kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/util/file.cpp: 120, 143
kdenetwork-1052214/kopete/plugins/nowlistening/nowlisteningplugin.cpp: 117

suggest parentheses around assignment used as truth value

kdenetwork-1052214/kopete/protocols/oscar/liboscar/tasks/filetransfertask.cpp: 818
kdenetwork-1052214/kopete/protocols/sms/services/smssendprovider.cpp: 235

suggest parentheses around within

kdenetwork-1052214/kopete/libkopete/kopetepropertycontainer.cpp: 139
kdenetwork-1052214/kopete/protocols/jabber/libiris/iris/xmpp/xmpp-core/xmlprotocol.cpp: 154, 155, 156

overflow in implicit constant conversion

kdenetwork-1052214/kopete/protocols/oscar/liboscar/tasks/messagereceivertask.cpp: 353
kdenetwork-1052214/krdc/zeroconf/zeroconfpage.cpp: 122

const was hidden

kdenetwork-1052214/kopete/libkopete/kopetemimetypehandler.h: 82, 74
kdenetwork-1052214/kopete/protocols/groupwise/libgroupwise/task.h: 78

may be used uninitialized in this function

kdenetwork-1052214/kopete/protocols/groupwise/libgroupwise/tasks/chatcountstask.cpp: 67
kdenetwork-1052214/kopete/protocols/jabber/jabberchatsession.cpp: 221, 220
kdenetwork-1052214/kopete/protocols/jabber/libiris/iris/xmpp/xmpp-im/s5b.cpp: 1039

#warning

kdenetwork-1052214/filesharing/advanced/nfs/nfsdialog.cpp: 91
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/net/socket.cpp: 333
kdenetwork-1052214/kopete/protocols/groupwise/ui/gwprivacydialog.cpp: 315

defined but not used

kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/dht/rpcserver.cpp: 101
kdenetwork-1052214/kopete/protocols/jabber/libiris/iris/xmpp/xmpp-core/protocol.cpp: 44
kdenetwork-1052214/kopete/protocols/skype/skypebuttons/qtbrowserplugin/qtbrowserplugin.cpp: 282, 291

by const

kdenetwork-1052214/kopete/protocols/groupwise/libgroupwise/tasks/eventtask.h: 37
kdenetwork-1052214/kopete/protocols/groupwise/libgroupwise/tasks/requesttask.h: 38
kdenetwork-1052214/kopete/protocols/oscar/aim/aimprotocol.h: 32
kdenetwork-1052214/kopete/protocols/oscar/icq/icqprotocol.h: 31

dereferencing pointer does break strict-aliasing rules

/opt/testing/include/k3socketaddress.h: 343, 344
/usr/include/QtCore/qmap.h: 588
kdenetwork-1052214/kppp/pppstats.cpp: 240, 251
kdenetwork-1052214/krfb/connectioncontroller.cpp: 49

function might be possible candidate for format attribute

kdenetwork-1052214/kopete/protocols/jabber/libiris/iris/jdns/jdns_util.c: 101
kdenetwork-1052214/kopete/protocols/jabber/libiris/iris/xmpp/xmpp-im/xmpp_task.cpp: 233
kdenetwork-1052214/krdc/vnc/vncclientthread.cpp: 129
rtf.ll: 313, 316

was hidden

/opt/testing/include/k3listviewsearchline.h: 199
/opt/testing/include/k3socketbase.h: 701, 736
/opt/testing/include/kcmodule.h: 215
/usr/include/Qt3Support/q3textedit.h: 363
kdenetwork-1052214/kopete/libkopete/kopetecontact.h: 236, 231
kdenetwork-1052214/kopete/protocols/oscar/aim/../oscarmyselfcontact.h: 44

enumeration value not handled in switch

kdenetwork-1052214/kget/transfer-plugins/bittorrent/advanceddetails/iwfilelistmodel.cpp: 99
kdenetwork-1052214/kget/transfer-plugins/bittorrent/advanceddetails/iwfiletreemodel.cpp: 104
kdenetwork-1052214/kopete/libkopete/avdevice/videodevicepool.cpp: 446
kdenetwork-1052214/kopete/plugins/pipes/pipesplugin.cpp: 206
kdenetwork-1052214/kopete/protocols/bonjour/bonjourcontactconnection.cpp: 177, 312, 346
kdenetwork-1052214/kopete/protocols/skype/libskype/skypedbus/skypeconnection.cpp: 104

unused variable

kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/sharedlgimpl.cpp: 300
kdenetwork-1052214/filesharing/simple/groupconfigdlg.cpp: 294
kdenetwork-1052214/kopete/libkopete/avdevice/videodevice.cpp: 1365, 1369
kdenetwork-1052214/kopete/libkopete/ui/kopetelistviewitem.cpp: 1207
kdenetwork-1052214/kopete/protocols/groupwise/gwaccount.cpp: 969
kdenetwork-1052214/kopete/protocols/qq/evautil.cpp: 69
kdenetwork-1052214/kopete/protocols/qq/ui/qqeditaccountwidget.cpp: 83

ignoring return value of , declared with attribute warn_unused_result

kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/dht/rpcserver.cpp: 125
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/tracker/udptrackersocket.cpp: 180
kdenetwork-1052214/kopete/plugins/history/converter.cpp: 143, 148, 159, 164
kdenetwork-1052214/kopete/protocols/jabber/libiris/iris/irisnet/noncore/processquit.cpp: 125, 164, 208
kdenetwork-1052214/kppp/accounts.cpp: 226
kdenetwork-1052214/kppp/connect.cpp: 1447, 1457, 1461, 1483, 1499, 1501, 1536, 1537, 1541
kdenetwork-1052214/kppp/main.cpp: 344, 396, 399
kdenetwork-1052214/kppp/modem.cpp: 417, 582
kdenetwork-1052214/kppp/opener.cpp: 225
rtf.ll: 57

const

kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/dictmanager.cpp: 210
kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/kcmsambaconf.cpp: 385, 1133, 1258
kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/linuxpermissionchecker.cpp: 159, 160, 161, 182, 183, 184
kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/qmultichecklistitem.cpp: 127
kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/sharedlgimpl.cpp: 360
kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/socketoptionsdlg.ui.h: 68, 91, 100
kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/usertabimpl.cpp: 389
kdenetwork-1052214/filesharing/simple/groupconfigdlg.cpp: 123, 155
kdenetwork-1052214/kopete/libkopete/kopetefileengine.cpp: 95, 122
kdenetwork-1052214/kopete/libkopete/ui/kopetelistviewitem.cpp: 829, 1212, 1272, 1278
kdenetwork-1052214/kopete/protocols/groupwise/ui/gwprivacydialog.cpp: 116, 206
kdenetwork-1052214/kopete/protocols/jabber/jabberxdatawidget.cpp: 310

by

/opt/testing/include/k3clientsocketbase.h: 452, 463
/opt/testing/include/k3socketdevice.h: 265, 275
/usr/include/Qt3Support/q3multilineedit.h: 88
kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/kcmsambaconf.h: 75
kdenetwork-1052214/kopete/libkopete/ui/kopetelistviewsearchline.h: 47
kdenetwork-1052214/kopete/protocols/bonjour/bonjourcontact.h: 80
kdenetwork-1052214/kopete/protocols/groupwise/gwcontact.h: 102
kdenetwork-1052214/kopete/protocols/oscar/aim/aimaccount.h: 61
kdenetwork-1052214/kopete/protocols/oscar/aim/aimcontact.h: 38
kdenetwork-1052214/kopete/protocols/oscar/aim/icqcontact.h: 53
kdenetwork-1052214/kopete/protocols/oscar/icq/aimcontact.h: 43
kdenetwork-1052214/kopete/protocols/oscar/icq/icqcontact.h: 50
kdenetwork-1052214/kopete/protocols/qq/qqcontact.h: 96
kdenetwork-1052214/kopete/protocols/skype/skypecontact.h: 84
kdenetwork-1052214/kopete/protocols/sms/smscontact.h: 38
kdenetwork-1052214/kopete/protocols/testbed/testbedcontact.h: 60
kdenetwork-1052214/kopete/protocols/winpopup/wpcontact.h: 55
kdenetwork-1052214/kopete/protocols/yahoo/yahoocontact.h: 53

comparison between signed and unsigned integer expressions

kdenetwork-1052214/kget/transfer-plugins/bittorrent/advanceddetails/webseedsmodel.cpp: 137
kdenetwork-1052214/kget/transfer-plugins/bittorrent/bttransfer.cpp: 250, 256
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/dht/announcetask.cpp: 147
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/dht/database.cpp: 106
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/dht/kbucket.cpp: 137
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/dht/key.cpp: 43
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/dht/pack.cpp: 40, 51, 65, 80
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/dht/rpcserver.cpp: 104
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/download/httpconnection.cpp: 171
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/migrate/cachemigrate.cpp: 62
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/net/downloadthread.cpp: 159
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/peer/authenticationmonitor.cpp: 95
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/peer/packetreader.cpp: 150
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/tracker/udptracker.cpp: 142
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/tracker/udptrackersocket.cpp: 164
kdenetwork-1052214/kopete/kopete/config/avdevice/avdeviceconfig.cpp: 168
kdenetwork-1052214/kopete/protocols/groupwise/gwmessagemanager.cpp: 185, 206
kdenetwork-1052214/kopete/protocols/groupwise/libgroupwise/inputprotocolbase.cpp: 101
kdenetwork-1052214/kopete/protocols/oscar/liboscar/inputprotocolbase.cpp: 90
kdenetwork-1052214/kopete/protocols/qq/qqchatsession.cpp: 149, 171

is deprecated

/opt/testing/include/KDE/../k3process.h: 214, 218, 224, 232, 547, 568, 605, 613
/opt/testing/include/k3process.h: 214, 218, 224, 232, 547, 568, 605, 613
kdenetwork-1052214/build/filesharing/advanced/kcm_sambaconf/sambafile.moc: 81
kdenetwork-1052214/build/filesharing/advanced/kcm_sambaconf/smbpasswdfile.moc: 67
kdenetwork-1052214/build/filesharing/advanced/propsdlgplugin/sambafile.moc: 81
kdenetwork-1052214/build/filesharing/advanced/propsdlgplugin/smbpasswdfile.moc: 67
kdenetwork-1052214/build/filesharing/simple/sambafile.moc: 81
kdenetwork-1052214/build/filesharing/simple/smbpasswdfile.moc: 67
kdenetwork-1052214/build/kopete/libkopete/kopetecommandhandler.moc: 94, 95
kdenetwork-1052214/build/kopete/protocols/sms/smsclient.moc: 76, 77
kdenetwork-1052214/build/kopete/protocols/sms/smssendprovider.moc: 76, 77
kdenetwork-1052214/build/kppp/accounting.moc: 213
kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/kcminterface.cpp: 114
kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/sambafile.cpp: 347, 375, 398
kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/sambafile.h: 168
kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/sharedlgimpl.cpp: 624
kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/smbpasswdfile.cpp: 116, 188
kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/smbpasswdfile.h: 140
kdenetwork-1052214/kopete/libkopete/kopetecommandhandler.cpp: 114, 314, 316, 385, 400
kdenetwork-1052214/kopete/libkopete/kopetecommandhandler.h: 186, 187
kdenetwork-1052214/kopete/protocols/sms/services/smsclient.cpp: 75, 157, 164
kdenetwork-1052214/kopete/protocols/sms/services/smsclient.h: 47, 48
kdenetwork-1052214/kopete/protocols/sms/services/smssendprovider.cpp: 241, 255, 266
kdenetwork-1052214/kopete/protocols/sms/services/smssendprovider.h: 54, 55
kdenetwork-1052214/kppp/accounting.cpp: 385, 442
kdenetwork-1052214/kppp/accounting.h: 134, 140

unused parameter

kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/kcmsambaconf.cpp: 185
kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/sambafile.cpp: 464
kdenetwork-1052214/filesharing/advanced/kcm_sambaconf/sharedlgimpl.cpp: 567, 582, 597
kdenetwork-1052214/filesharing/advanced/propsdlgplugin/propertiespage.cpp: 536
kdenetwork-1052214/kget/transfer-plugins/bittorrent/bttransferfactory.cpp: 92
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/dht/dht.cpp: 323
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/dht/kbucket.cpp: 149
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/interfaces/chunkselectorinterface.cpp: 36
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/migrate/ccmigrate.cpp: 59
kdenetwork-1052214/kget/transfer-plugins/bittorrent/libbtcore/net/downloadthread.cpp: 127
kdenetwork-1052214/kget/transfer-plugins/multisegmentkio/multisegkio.cpp: 179
kdenetwork-1052214/kget/transfer-plugins/multisegmentkio/multisegkiodatasource.cpp: 52
kdenetwork-1052214/kopete/kopete/config/accounts/kopeteaccountconfig.cpp: 481
kdenetwork-1052214/kopete/kopete/config/avdevice/avdeviceconfig.cpp: 240, 258
kdenetwork-1052214/kopete/kopete/contactlist/kabcexport.cpp: 155
kdenetwork-1052214/kopete/libkopete/kopetechatsession.cpp: 419, 531
kdenetwork-1052214/kopete/libkopete/kopeteidentity.cpp: 270
kdenetwork-1052214/kopete/libkopete/tests/mock/kopeteaccount_mock.cpp: 41, 46, 56, 61
kdenetwork-1052214/kopete/libkopete/tests/mock/kopetecontact_mock.cpp: 37
kdenetwork-1052214/kopete/libkopete/tests/mock/kopeteprotocol_mock.cpp: 33, 38, 43
kdenetwork-1052214/kopete/protocols/bonjour/bonjouraccount.cpp: 99
kdenetwork-1052214/kopete/protocols/bonjour/bonjouraddcontactpage.cpp: 46
kdenetwork-1052214/kopete/protocols/bonjour/bonjourcontact.cpp: 60
kdenetwork-1052214/kopete/protocols/bonjour/bonjourcontactconnection.cpp: 255
kdenetwork-1052214/kopete/protocols/groupwise/gwaccount.cpp: 374
kdenetwork-1052214/kopete/protocols/groupwise/gwconnector.cpp: 49
kdenetwork-1052214/kopete/protocols/groupwise/ui/gwchatsearchdialog.cpp: 37
kdenetwork-1052214/kopete/protocols/groupwise/ui/gwprivacydialog.cpp: 54
kdenetwork-1052214/kopete/protocols/groupwise/ui/gwreceiveinvitationdialog.cpp: 37
kdenetwork-1052214/kopete/protocols/groupwise/ui/gwsearch.cpp: 70
kdenetwork-1052214/kopete/protocols/jabber/libiris/iris/xmpp/jingle/jinglesession.cpp: 142
kdenetwork-1052214/kopete/protocols/jabber/libiris/iris/xmpp/jingle/jinglesessionmanager.cpp: 266
kdenetwork-1052214/kopete/protocols/jabber/libiris/iris/xmpp/xmpp-core/protocol.cpp: 795, 802, 860, 867
kdenetwork-1052214/kopete/protocols/qq/evautil.cpp: 50
kdenetwork-1052214/kopete/protocols/qq/qqaccount.cpp: 143
kdenetwork-1052214/kopete/protocols/skype/skypechatsession.cpp: 42
kdenetwork-1052214/kopete/protocols/sms/smsaccount.cpp: 189
kdenetwork-1052214/kopete/protocols/testbed/testbedaccount.cpp: 78
kdenetwork-1052214/kopete/protocols/winpopup/wpaccount.cpp: 206
kdenetwork-1052214/kopete/protocols/yahoo/libkyahoo/libyahoo.c: 87
kdenetwork-1052214/kopete/protocols/yahoo/libkyahoo/logintask.cpp: 224
kdenetwork-1052214/kopete/protocols/yahoo/yahooaccount.cpp: 843, 1861